Repository navigation
fix(studio): stop local analysis across client stages - #2662
Open
groupthinking wants to merge 2 commits into
Open
groupthinking wants to merge 2 commits into
groupthinking wants to merge 2 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
github-actions
Bot
added
javascript
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
groupthinking
marked this pull request as ready for review
November 13, 2026 18:37
groupthinking
added a commit
that referenced
this pull request
Nov 13, 2026
Closes #2659 ## Outcome Build live preserves failed or missing hosted health after stored-pack recovery. Healthy initial and retry paths remain covered. ## Scope and risk The production change removes the ten-line failed-health success bypass; regression tests cover failed health, missing health and unsuccessful HTTP responses. Risk is low. The temporary no-deployment configuration has been removed. Hayden explicitly authorized preview deployments, E2E validation, then merge and automatic production deployment only if validation passes on November 13, 2026. No check bypass or acceptance weakening is authorized. ## Verification Current head: `3825e30b8a443b1d777a581a8ef496ce80b3f7d3`; tree `cc4240b370ad1fec772ffec645a8bcf10fd31bbf`. This update changes deployment configuration only; the application code and tests are unchanged from the independently reviewed fix. Focused readiness checks: 29 passed; standalone web suite: 1,568 passed and 28 skipped. The negative control failed two tests against the original source. Both fixes together passed a fresh current-main local rerun: 1,581 web tests with 28 skipped across 172 files; full web type-check and lint passed. The validated combined current-main tree is 08bd6950052241259d30c2da20897c5c9e2b5fa0. Both also combine cleanly with current main `512a2558f73d6281b6a880548bedf140b7e30292`, which adds only the independent runtime npm repair. Earlier heads passed hosted build, unit, coverage, CodeQL and security workflow checks, but E2E failed before execution because previews were disabled. Those earlier successes are historical, not current-head acceptance. New exact-head preview CI and E2E completed successfully. Hosted build, web/Python tests, real-service preflight, security workflows, CodeQL, coverage, metadata and issue closer passed before merge preparation. A green report that skipped ready-pack assertions is not accepted as ready-pack evidence. The canonical fixture `auJzb1D-fag` was read-only preflighted on production: HTTP 200, success, current `p1.6-direct-shard-v1` pack and 6,504 transcript characters. This does not prove a fresh extraction or a deployed app generated from the video. ## Release and rollback Codex owns current-head checks, review findings, exact-head-protected merge, and production verification. Mark this draft ready only after validation. No merge has occurred. Rollback is a separately reviewed revert; it would restore the prior incorrect readiness behavior. Durable server cancellation and general video-to-production generation remain separate from this correction. Related correction: #2662. ## Verified preview acceptance - Exact-head preview: https://v0-uvai-9621mle7n-garv1.vercel.app. - E2E: 16/16 passed, including ready-pack evidence lineage, with no timeout-based skipping of shape assertions. [Receipt](https://github.com/groupthinking/EventRelay/actions/runs/43483242872/job/132084905049). - Individual Vercel deployment is Ready and bound to this head. Generic HTTP E2E is distinct from the focused regression tests for the fix. - No unresolved review threads or additional blocking source finding at final review.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2660
Outcome
Cancel stops active client requests and later stages, restores Run immediately, preserves request timeouts, and isolates stale UI callbacks. Work already accepted by the server may continue.
Scope and risk
The production change propagates AbortSignal through pack requests, polling and workflow start, guards stage transitions, and stops local rows immediately. Regression tests cover abort timing, late results, replacement runs and timeout preservation. Risk is medium.
The temporary no-deployment configuration has been removed. Hayden explicitly authorized preview deployments, E2E validation, then merge and automatic production deployment only if validation passes on November 13, 2026. No check bypass or acceptance weakening is authorized.
Verification
Current head:
81dcf15e49cdfe29efe3423374ac098f5d3f1234; treea902b1bf91a6375f91a5ac4a355d5da7c3b801d5. This update changes deployment configuration only; the application code and tests are unchanged from the independently reviewed fix.Focused cancellation checks: 97 passed across eight files. New regressions failed before correction. Independent review caught the displaced kickoff timeout; it is composed correctly and tested.
Both fixes together passed a fresh current-main local rerun: 1,581 web tests with 28 skipped across 172 files; full web type-check and lint passed. The validated combined current-main tree is 08bd6950052241259d30c2da20897c5c9e2b5fa0. Both also combine cleanly with current main
512a2558f73d6281b6a880548bedf140b7e30292, which adds only the independent runtime npm repair.Earlier heads passed hosted build, unit, coverage, CodeQL and security workflow checks, but E2E failed before execution because previews were disabled. Those earlier successes are historical, not current-head acceptance. New exact-head preview CI and E2E completed successfully. Hosted build, web/Python tests, real-service preflight, security workflows, CodeQL, coverage, metadata and issue closer passed before merge preparation. A green report that skipped ready-pack assertions is not accepted as ready-pack evidence.
The canonical fixture
auJzb1D-fagwas read-only preflighted on production: HTTP 200, success, currentp1.6-direct-shard-v1pack and 6,504 transcript characters. This does not prove a fresh extraction or a deployed app generated from the video.Release and rollback
Codex owns current-head checks, review findings, exact-head-protected merge, and production verification. Mark this draft ready only after validation. No merge has occurred.
Rollback is a separately reviewed revert; it would restore the prior incomplete cancellation behavior. Durable server cancellation and general video-to-production generation remain separate from this correction.
Related correction: #2661.
Verified preview acceptance